Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata plugin for ksk yaml files #833

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Conversation

siliconfeces
Copy link
Contributor

This plugin parses the yaml files that exist in some ksk archives. It requires an additional CPAN module, and I haven't tested it on any recent archive. It's a bit old and I've mostly just rebased the branch before opening the PR. At least the tests are green!

Since the metadata doesn't exist in all files, or even the most recent ones, I kind of gave up on this plugin. In other words, no hard feelings if you skip this PR.

@Difegue
Copy link
Owner

Difegue commented Aug 4, 2023

Looks good! CI is failing on the GH side because it's using a Docker image without YAML::Syck as the base, but that'll fix itself once merged.

I don't think the plugin itself is that useful since ksk doesn't really include yamls anymore as mentioned, but I still think it's good to have an example available for YAML metadata files people can hack on for their own weird sidecar files. Thanks!

@Difegue Difegue merged commit 2d38020 into Difegue:dev Aug 4, 2023
@holopin-bot
Copy link

holopin-bot bot commented Aug 4, 2023

Congratulations @siliconfeces, you just earned a holobyte! Here it is: https://holopin.io/holobyte/clkx1suz879950fmi8s8q28l2

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@siliconfeces siliconfeces deleted the kskplug branch August 28, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants